Skip to content

Add RetainFirstAdmission migration mode for concurrent admissions#11236

Merged
k8s-ci-robot merged 1 commit into
kubernetes-sigs:mainfrom
epam:feat/10911
May 22, 2026
Merged

Add RetainFirstAdmission migration mode for concurrent admissions#11236
k8s-ci-robot merged 1 commit into
kubernetes-sigs:mainfrom
epam:feat/10911

Conversation

@reruno
Copy link
Copy Markdown
Member

@reruno reruno commented May 15, 2026 •
edited
Loading

…n a Workload to its first admitted flavor

What type of PR is this?

/kind feature

What this PR does / why we need it:

Add HoldFirstAdmission migration mode for concurrent admissions to pin a Workload to its first admitted flavor

Which issue(s) this PR fixes:

Fixes #10911

Special notes for your reviewer:

Unit Test code coverage

sigs.k8s.io/kueue/pkg/controller/concurrentadmission/controller.go:360: deactivateMatchingVariants      90.0%
sigs.k8s.io/kueue/pkg/controller/concurrentadmission/controller.go:376: deactivateVariants              92.0%
sigs.k8s.io/kueue/pkg/controller/concurrentadmission/controller.go:446: activateVariants                87.5%
sigs.k8s.io/kueue/pkg/controller/concurrentadmission/controller.go:644: migrationMode                   66.7%

concurrentadmission.html

Unit test code coverage Web hook

sigs.k8s.io/kueue/pkg/webhooks/clusterqueue_webhook.go (89.8%)

cq_webhook_cover.html

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented May 15, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. labels May 15, 2026
@netlify
Copy link
Copy Markdown

netlify Bot commented May 15, 2026 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
🔨 Latest commit 8e3ed45
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-sigs-kueue/deploys/6a103405e0412a0008b9bf19

@k8s-ci-robot k8s-ci-robot requested review from PBundyra and kannon92 May 15, 2026 12:57
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 15, 2026
@reruno reruno marked this pull request as ready for review May 15, 2026 12:58
@reruno reruno force-pushed the feat/10911 branch 5 times, most recently from 738f04c to 58b5d06 Compare May 18, 2026 07:41
@mimowo
Copy link
Copy Markdown
Contributor

mimowo commented May 19, 2026

cc @PBundyra ptal

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 19, 2026
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 19, 2026
PBundyra
PBundyra suggested changes May 19, 2026
View reviewed changes
Comment thread cmd/experimental/kueue-priority-booster/charts/kueue-priority-booster/values.yaml
Comment thread pkg/webhooks/clusterqueue_webhook.go
Comment thread test/integration/singlecluster/controller/concurrentadmission/concurrent_admission_test.go Outdated
Comment thread pkg/controller/concurrentadmission/controller_test.go Outdated
Comment thread pkg/controller/concurrentadmission/controller.go Outdated
@reruno reruno force-pushed the feat/10911 branch 2 times, most recently from 2b28c46 to 1244122 Compare May 20, 2026 09:41
@reruno
Copy link
Copy Markdown
Member Author

reruno commented May 20, 2026 •
edited
Loading

/retest

created flake issue #11351

@reruno reruno changed the title [WIP] Add HoldFirstAdmission migration mode for concurrent admissions to pi… Add HoldFirstAdmission migration mode for concurrent admissions to pi… May 20, 2026
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 20, 2026
@PBundyra
Copy link
Copy Markdown
Contributor

PBundyra commented May 20, 2026

/hold
/lgtm
Code wise it looks good to me, thanks for the contribution.

I'm putting this on hold as we're discussing if HoldFirstAdmission is the best name for this mode or if it needs renaming
/cc @mimowo @tenzen-y

@k8s-ci-robot k8s-ci-robot requested a review from mimowo May 20, 2026 12:58
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 20, 2026
@k8s-ci-robot k8s-ci-robot requested a review from PBundyra May 20, 2026 13:00
@PBundyra
Copy link
Copy Markdown
Contributor

PBundyra commented May 22, 2026

After some discussion with approvers we've decided the best name for this mode would be RetainFirstAdmission. @reruno Could you please rename the mode accordingly both in your PR and in the KEP?

mimowo
mimowo reviewed May 22, 2026
View reviewed changes
Comment thread test/integration/singlecluster/controller/concurrentadmission/concurrent_admission_test.go Outdated
mimowo
mimowo reviewed May 22, 2026
View reviewed changes
Comment thread test/integration/singlecluster/controller/concurrentadmission/concurrent_admission_test.go Outdated
mimowo
mimowo reviewed May 22, 2026
View reviewed changes
Comment thread pkg/controller/concurrentadmission/controller.go Outdated
mimowo
mimowo reviewed May 22, 2026
View reviewed changes
Comment thread pkg/controller/concurrentadmission/controller.go Outdated
mimowo
mimowo reviewed May 22, 2026
View reviewed changes
Comment thread pkg/controller/concurrentadmission/controller.go
@mimowo
Copy link
Copy Markdown
Contributor

mimowo commented May 22, 2026 •
edited
Loading

Assuming the ConcurrentAdmission Feature is released in 0.18 I don't think we need a release note specific to this field.
We will add release note in case this extension slips 0.18.

/release-note-edit

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels May 22, 2026
@mimowo
Copy link
Copy Markdown
Contributor

mimowo commented May 22, 2026

LGTM overall, please address my comments and update the KEP. I think this is pretty much ready to go

@mimowo
Copy link
Copy Markdown
Contributor

mimowo commented May 22, 2026

/retest

@mimowo
Copy link
Copy Markdown
Contributor

mimowo commented May 22, 2026

/retitle Add RetainFirstAdmission migration mode for concurrent admissions

@k8s-ci-robot k8s-ci-robot changed the title Add HoldFirstAdmission migration mode for concurrent admissions to pi… Add RetainFirstAdmission migration mode for concurrent admissions May 22, 2026
@mimowo
Copy link
Copy Markdown
Contributor

mimowo commented May 22, 2026

/lgtm
/approve
Thank you 👍
Feel free to unhols when you confirm stability locally as requested in #11236 (comment)

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 22, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented May 22, 2026

LGTM label has been added.

DetailsGit tree hash: a57798a187b3cd49a82b6823f901ba613c6d81ac

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented May 22, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mimowo, reruno

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 22, 2026
@reruno
Copy link
Copy Markdown
Member Author

reruno commented May 22, 2026

/unhold

#11236 (comment)
#11236 (comment)

100 local runs finished successfully

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 22, 2026
@k8s-ci-robot k8s-ci-robot merged commit 8bce0d5 into kubernetes-sigs:main May 22, 2026
37 of 39 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v0.18 milestone May 22, 2026
@reruno reruno deleted the feat/10911 branch May 22, 2026 12:52
@tenzen-y
Copy link
Copy Markdown
Member

tenzen-y commented May 22, 2026

After some discussion with approvers we've decided the best name for this mode would be RetainFirstAdmission. @reruno Could you please rename the mode accordingly both in your PR and in the KEP?

Thanks for handling this mode, @PBundyra @reruno

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mimowo mimowo mimowo left review comments

@kannon92 kannon92 Awaiting requested review from kannon92

@mbobrovskyi mbobrovskyi Awaiting requested review from mbobrovskyi

@tenzen-y tenzen-y Awaiting requested review from tenzen-y

@PBundyra PBundyra Awaiting requested review from PBundyra

Assignees

@mimowo mimowo

@PBundyra PBundyra

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

v0.18

Development

Successfully merging this pull request may close these issues.

[ConcurrentAdmission] Add HoldFirstAdmission mode support

5 participants

@reruno @k8s-ci-robot @mimowo @PBundyra @tenzen-y